Skip to content

Update bindgen to fix building with llvm 18#5700

Merged
fuzyll merged 1 commit into
Vector35:test_update_bindgenfrom
mkrasnitski:bindgen
Jul 11, 2024
Merged

Update bindgen to fix building with llvm 18#5700
fuzyll merged 1 commit into
Vector35:test_update_bindgenfrom
mkrasnitski:bindgen

Conversation

@mkrasnitski
Copy link
Copy Markdown
Contributor

LLVM 18 broke compatibility with bindgen 0.68 by fixing a longstanding bug (see slack discussion), and this issue was fixed in 0.69.2.

@jrozner
Copy link
Copy Markdown
Contributor

jrozner commented Jul 11, 2024

Is it possible to get this merged in before the next release? Not doing so means that building Rust plugins for 4.2 just won't be possible on windows with llvm 18+

@fuzyll fuzyll changed the base branch from dev to test_update_bindgen July 11, 2024 18:07
@fuzyll fuzyll merged commit bb7e6b3 into Vector35:test_update_bindgen Jul 11, 2024
@fuzyll
Copy link
Copy Markdown
Contributor

fuzyll commented Jul 11, 2024

Merging this into a different branch to test it through our CI. Trying to get this in through code freeze for 4.1.

@mkrasnitski mkrasnitski deleted the bindgen branch July 12, 2024 17:48
@fuzyll
Copy link
Copy Markdown
Contributor

fuzyll commented Jul 12, 2024

This hasn't shown up in a dev build yet, but CI passed yesterday and we've pulled it into the new release as of today. Thanks!

@fuzyll fuzyll added this to the Elysium milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants