[SharedCache] Fix uninitialized loaded field for mappings returned by BNDSCViewGetAllImages#6285
Merged
Conversation
0cyn
force-pushed
the
fix-loaded-BNDSCViewGetAllImages
branch
from
4c07c97 to
8f83f6e
Compare
…by `BNDSCViewGetAllImages`
0cyn
force-pushed
the
fix-loaded-BNDSCViewGetAllImages
branch
from
8f83f6e to
faac469
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BNDSCViewGetAllImageswas not initializing the fieldloadedonBNDSCImageMemoryMappingentries in the mappings array for eachBNDSCImage. This would result in uninitialized values being returned, incorrectly indicating whether a memory region for an image was loaded or not.The fix asks the binary view if a section start address is a valid offset to determine if the mapping is loaded or not. I'm not sure if this is the most performant solution but it fixes the issue.