Skip to content

MSVC RTTI improvements#6331

Closed
nullableVoidPtr wants to merge 4 commits into
Vector35:devfrom
nullableVoidPtr:dev
Closed

MSVC RTTI improvements#6331
nullableVoidPtr wants to merge 4 commits into
Vector35:devfrom
nullableVoidPtr:dev

Conversation

@nullableVoidPtr
Copy link
Copy Markdown
Contributor

@nullableVoidPtr nullableVoidPtr commented Jan 20, 2025

  • Define attribute enumerations for BaseClassDescriptors and ClassHierarchyDescriptors
  • Recursively define ClassHierarchyDescriptor and TypeDescriptor structs referenced by BaseClassDescriptor
    • Some base classes do not have a corresponding coLocator referencing them.
  • Use the the name of the first base class for ClassInfo instead of the last matching base class

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 20, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@psifertex psifertex requested a review from emesare January 20, 2025 16:20
@emesare emesare self-assigned this Jan 20, 2025
@nullableVoidPtr
Copy link
Copy Markdown
Contributor Author

Hi, any blockers to this getting merged? I've already signed the CLA.

@emesare
Copy link
Copy Markdown
Member

emesare commented Jan 22, 2025

Hi, any blockers to this getting merged? I've already signed the CLA.

The CI for new dev builds is currently halted so it has not been a priority to merge this, as there would be no dev build going out for this until that is resolved. I will check the status when I am back in the office tomorrow.

We do not need anything from your end so you once this is merged I will let you know the dev build number that this lands on. Thank you!

@emesare
Copy link
Copy Markdown
Member

emesare commented Jan 25, 2025

Sorry again for the delay! Your code has been merged and will be on dev builds >= 6739.

https://github.com/Vector35/binaryninja-api/commits/dev/?author=nullableVoidPtr&since=2025-01-25&until=2025-01-25

Thank you for your PR!

@emesare emesare closed this Jan 25, 2025
@emesare emesare added this to the Gallifrey milestone Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants