[SharedCache] Add a section for sectionless segments#6513
Closed
WeiN76LQh wants to merge 1 commit into
Closed
Conversation
In Binary Ninja it can be quite confusing when a segment is added that doesn't have any sections. `libobjc.A.dylib::__OBJC_RW` is an example of this. When scrolling through that segment there is no bar at the top of the linear view indicating where the data came from. When looking at the list of segments there are no names and with the different segment and section lists it can be hard to eyeball where a segment lands within the list of sections. There is an argument here that the better solution is to change the way Binary Ninja displays information. For instance when scrolling through the linear view through a segment with no section, the segment information should be displayed at the top. Additionally segment names could be displayed in the segment list.
WeiN76LQh
pushed a commit
to WeiN76LQh/binaryninja-api
that referenced
this pull request
Mar 23, 2025
Similar to what is discussed in PR Vector35#6513 its useful to be able to see where an image header is as sometimes you want to inspect the load commands. Without a section its not very obvious where the header is. The naming scheme of `${imageName}::__header` was chosen based on the naming choice of the DSC header.
Contributor
|
I am of the opinion that the solution here is to:
I think the golden standard would be sections in the view accurately reflecting sections in memory. There could be analysis repercussions from this. I'll invite further discussion on the topic. |
Author
|
I agree with all of that, this was just a stop gap solution because I didn't see any movement in that space in the time being and this didn't feel too problematic to implement for the time being. |
Contributor
|
Hi! Thank you so much for the PR! After some internal discussion we've decided that we'd like to continue working towards a proper full solution for this rather than a bandaid fix, and discussion/progress can be tracked further via #7602 . Thank you again for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Binary Ninja it can be quite confusing when a segment is added that doesn't have any sections.
libobjc.A.dylib::__OBJC_RWis an example of this. When scrolling through that segment there is no bar at the top of the linear view indicating where the data came from. When looking at the list of segments there are no names and with the different segment and section lists it can be hard to eyeball where a segment lands within the list of sections.There is an argument here that the better solution is to change the way Binary Ninja displays information. For instance when scrolling through the linear view through a segment with no section, the segment information should be displayed at the top. Additionally segment names could be displayed in the segment list.