Skip to content

[SharedCache] Apply call type overrides to objc_msgSendSuper / objc_msgSendSuper2 #6565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emesare merged 1 commit into from
Apr 8, 2025
Merged

[SharedCache] Apply call type overrides to objc_msgSendSuper / objc_msgSendSuper2 #6565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 25 additions & 4 deletions view/sharedcache/workflow/ObjCActivity.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,24 @@ void ObjCActivity::AdjustCallType(Ref<AnalysisContext> ctx)
if (insn.operation != LLIL_CALL_SSA)
return;

// Filter out calls that aren't to `objc_msgSend`.
enum class MessageSendType {
Normal,
Super,
};

MessageSendType messageSendType = MessageSendType::Normal;
// Filter out calls that aren't to `objc_msgSend`, `objc_msgSendSuper`, or `objc_msgSendSuper2`.
auto callExpr = insn.GetDestExpr<LLIL_CALL_SSA>();
if (auto symbol = bv->GetSymbolByAddress(callExpr.GetValue().value))
if (symbol->GetRawName() != "_objc_msgSend")
return;
{
std::string_view symbolName = symbol->GetRawNameRef();
if (symbolName == "_objc_msgSend")
messageSendType = MessageSendType::Normal;
else if (symbolName == "_objc_msgSendSuper2" || symbolName == "_objc_msgSendSuper")
messageSendType = MessageSendType::Super;
else
return;
}

const auto params = insn.GetParameterExprs<LLIL_CALL_SSA>();
// The second parameter passed to the objc_msgSend call is the address of
Expand Down Expand Up @@ -98,7 +111,15 @@ void ObjCActivity::AdjustCallType(Ref<AnalysisContext> ctx)
std::vector<FunctionParameter> callTypeParams;
auto cc = bv->GetDefaultPlatform()->GetDefaultCallingConvention();

callTypeParams.emplace_back("self", retType, true, Variable());
if (messageSendType == MessageSendType::Normal)
callTypeParams.emplace_back("self", retType, true, Variable());
else
{
auto superType = bv->GetTypeByName({ "objc_super" });
if (!superType)
superType = Type::PointerType(ssa->GetArchitecture(), Type::VoidType());
callTypeParams.emplace_back("super", Type::PointerType(ssa->GetArchitecture(), superType), true, Variable());
}

auto selType = bv->GetTypeByName({ "SEL" });
if (!selType)
Expand Down