[SharedCache] Dont apply invalid symbols in the stub workflow#6580
Merged
Conversation
emesare
added
the
File Format: SharedCache
emesare
force-pushed
the
dsc-fix-workflow-symbol-bug
branch
from
d246eb6 to
d32272d
Compare
Member
|
OK That should keep you as author, I just wanted to express the failure state in the return. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was no check to ensure
symbolactually had a value (as its astd::optional). This was resulting in invalid symbols being added.