Skip to content

[SharedCache] Always load image dependencies #6657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WeiN76LQh wants to merge 1 commit into from
Closed

[SharedCache] Always load image dependencies #6657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions view/sharedcache/ui/dsctriage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,11 @@ void DSCTriageView::loadImagesWithAddr(const std::vector<uint64_t>& addresses, b
for (const uint64_t& addr : addresses)
{
auto image = controller->GetImageContaining(addr);
// Only try to load if we have not already.
if (image.has_value() && !controller->IsImageLoaded(*image))
if (image.has_value())
{
images.insert({image->headerAddress, *image});
// Only try to load if we have not already.
if (!controller->IsImageLoaded(*image))
images.insert({image->headerAddress, *image});

// TODO: We currently only add direct dependencies, may want to make the depth configurable?
if (includeDependencies)
Expand Down