[SharedCache] Avoid reading header fields outside of the header for iOS 10 and older#6777
Closed
droe wants to merge 1 commit into
Closed
[SharedCache] Avoid reading header fields outside of the header for iOS 10 and older#6777droe wants to merge 1 commit into
droe wants to merge 1 commit into
Conversation
Use mappingOffset as an upper bound for the header size, and avoid reading any header fields from beyond that offset.
Member
|
LGTM |
emesare
added
the
File Format: SharedCache
Member
|
Cherry picked on dev with c925399 to cleanup some of the old TODO comments and return false on unknown platform. Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use mappingOffset as an upper bound for the header size, and avoid reading any header fields from beyond that offset.
Fixes the remaining aspects of #6073.
Tested against 5.1.7363-dev (acd6c39c)