[Mach-O] Handling for special library ordinals used in binding information#7078
Merged
Conversation
bdash
reviewed
Jul 11, 2025
| { | ||
| BNRelocationInfo info; | ||
| std::string name; | ||
| int8_t ordinal; |
Contributor
There was a problem hiding this comment.
I think this needs to be a larger type:
mrowe@quicksilver:~$ rg -B 2 lib_ordinal $(xcrun --show-sdk-path)/usr
/Applications/Xcode-16.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/mach-o/fixup-chains.h
301-struct dyld_chained_import
302-{
303: uint32_t lib_ordinal : 8, // -15 .. 240 (0xF1 .. 0xF0)
--
309-struct dyld_chained_import_addend
310-{
311: uint32_t lib_ordinal : 8, // -15 .. 240 (0xF1 .. 0xF0)
--
318-struct dyld_chained_import_addend64
319-{
320: uint64_t lib_ordinal : 16, // -15 .. 65520 (0xFFF1 .. 0xFFF0)
0cyn
force-pushed
the
chainedfixup_issues_6878
branch
from
76003da to
be9b667
Compare
0cyn
force-pushed
the
chainedfixup_issues_6878
branch
from
be9b667 to
2b3ce70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds handling for "BIND_SPECIAL_DYLIB_SELF" and related special library ordinals that influence symbol lookup when processing binding information.
External Info:
dyld - Symbol Lookup
Resolves #6878