Reserve vector capacity when populating vectors in conversion operators#7095
Merged
Conversation
plafosse
approved these changes
Jul 15, 2025
Member
plafosse
left a comment
There was a problem hiding this comment.
Very surprising all these were missing. This change should also reduce memory fragmentation which has been a huge cause of memory usage.
|
Related to this change, here is a performance profiling thought I once had:
Second profiling ideas:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed while looking at some performance profiles today that some of these conversion operators are used on relatively hot codepaths. Reserving capacity before populating them avoids reallocations as they grow and is free performance.