This repository was archived by the owner on Jun 25, 2025. It is now read-only.
[ObjC] Improve naming of arguments to Objective-C methods#69
Merged
Conversation
Detect and remove common prefixes used on selectors so that their arguments are more naturally named. For instance, a selector of `initWithURL:withStagedURL`: now ends up with arguments named `URL` and `stagedURL`, rather than `initWithURL` and `withStagedURL`.
|
Merged to repo, this will land in the product alongside the call rewrite PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect and remove common prefixes used on selectors so that their arguments are more naturally named. For instance, a selector of
initWithURL:withStagedURL: now ends up with arguments namedURLandstagedURL, rather thaninitWithURLandwithStagedURL.See also Vector35/binaryninja-api#6790.