test(release): add cli smoke readiness checks#23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds RR-002, a local CLI smoke and config/profile matrix readiness layer.
What changed
scripts/release_readiness/rr002_cli_smoke.shscripts/release_readiness/test_rr002_smoke.shpkg/profile/release_readiness_matrix_test.goscripts/release_readiness/readiness.shdocs/release/README.mdOperational posture
RR-002 behavior
RR-002 checks safe CLI/help behavior and config/profile invariants.
Safe CLI smoke currently covers:
gorkbot --helpgorkbot -hgorkweb --helpgorkweb -hUnsupported or unsafe commands are skipped/deferred:
--versionversionRR-002 writes reports to:
Current RR-002 recommendation:
because version commands are unsupported/deferred. This is expected and honest.
Config/profile matrix
The matrix verifies:
It covers trace/harness mode posture and verifies:
Main readiness integration
readiness.shnow includes RR-002 and still returns:because RR-003+ remain deferred.
It does not claim RC_READY or STABLE_READY.
Review status
Independent review verdict: APPROVE WITH MINOR FIXES.
Focused re-review verdict after fix: APPROVE.
The follow-up fix removed hardcoded
/tmpusage fromtest_rr002_smoke.shand made the smoke test portable to Termux/Android via${TMPDIR:-/tmp}+mktemp.Validation
bash scripts/release_readiness/test_smoke.shpassed.bash scripts/release_readiness/test_rr002_smoke.shpassed.bash scripts/release_readiness/rr002_cli_smoke.shpassed withRR002_INCOMPLETE.bash scripts/release_readiness/readiness.shpassed withNEEDS_RR_SUITE.bash scripts/check_promotion_manifest.shpassed with 908 / 908 managed files.go test ./...passed.go vet ./...passed.git diff --checkpassed.zero_proofs_3 | reasoning/classified as existing unrelated.Deferred follow-ups