Skip to content

pdf-canvas: Ignore extrenal graphics state parameters if not found #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Velli20 merged 1 commit into from
Apr 5, 2026
+4 −5
Merged

pdf-canvas: Ignore extrenal graphics state parameters if not found #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions crates/pdf-canvas/src/canvas_graphics_state_ops.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,10 @@ impl<B: CanvasBackend> GraphicsStateOps for PdfCanvas<'_, B> {
.resources
.ok_or(PdfCanvasError::MissingPageResources)?;

let states = resources
.external_graphics_state(dict_name)
.ok_or_else(|| PdfCanvasError::GraphicsStateNotFound(dict_name.to_string()))?;
let Some(states) = resources.external_graphics_state(dict_name) else {
// If the specified `ExtGState` is not found, the ignored parameters should not cause an error.
return Ok(());
};

for state in &states.params {
match state {
Expand Down
2 changes: 0 additions & 2 deletions crates/pdf-canvas/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ pub enum PdfCanvasError {
ColorSpaceNotFound(String),
#[error("Pattern '{0}' not found")]
PatternNotFound(String),
#[error("Graphics state dictionary '{0}' not found in resources")]
GraphicsStateNotFound(String),
#[error("Font '{0}' is a Type3 font but is missing its definition data")]
MissingType3FontData(String),
#[error(
Expand Down
Loading