Skip to content

Visitor now collects LET definitions #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scudette merged 1 commit into from
Sep 15, 2025
Merged

Visitor now collects LET definitions #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions visitor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ type CallSite struct {
type Visitor struct {
CallSites []CallSite

// A list of LET definitions
Definitions []CallSite

// Tokens added to the visitor as we encounter each token during
// parsing. Combining all the Fragments yields a reformatted
// query.
Expand Down Expand Up @@ -1049,13 +1052,32 @@ func (self *Visitor) visitVQL(node *VQL) {
if node.Parameters != nil {
self.push("(")
parameters := node.getParameters()
if self.opts.CollectCallSites {
callsite := CallSite{
Type: "definition",
Name: node.Let,
}

for _, p := range parameters {
callsite.Args = append(callsite.Args,
utils.Unquote_ident(p))
}
self.Definitions = append(self.Definitions, callsite)
}

for idx, p := range parameters {
self.push(p)
if idx < len(parameters)-1 {
self.push(",", " ")
}
}
self.push(")")

} else if self.opts.CollectCallSites {
self.Definitions = append(self.Definitions, CallSite{
Type: "definition",
Name: node.Let,
})
}
}
self.push(" ", operator, " ")
Expand Down