feat: Tray icon voice detection

[PolisanTheEasyNick]

epic pr🚀 cooking explodin
Resolves #294, partially resolves #667

• Show icons depending on current voice state

Any ideas about improving PR structure are welcome ^^

---

Voice Detection Icons

---

Notification Badge on top of Tray Icon

Special thanks to @MrGarlic1 and @Covkie

Also, on my repo, there is branch tray-icon-old where all changes with tray icons customizations, colors, and so on

[Korpyz]

It's a great feature, but I wanted to say that maybe the colors could be different. I barely see the icon in gnome where the bar is completely black. If you could choose a palette that benefits everyone that would be great. It seems very hidden indeed. for me tray icons vesktop always seem of low quality when compared with other Apps. These two are the last ones that look really bad in gnome. I believe it's just a palette choice like the white of the other tray icons

the color palette doesn't have to be white, just some color that benefits from black.

[PolisanTheEasyNick]

Thank you for feedback! I'm not using any black colors, I believe that it was just small border width. Also, I increased whole icon size. Can you please pull and retest?
What state is on your last screenshot? If it is muted or deafened that means that icons too small, and we need to redraw them completely, because I just took discord's original icons and changed colors to Vesktop ones. They are 24x24 pixels, so maybe they have not resized to proper size in Gnome system.

[Korpyz]

Thank you for feedback! I'm not using any black colors, I believe that it was just small border width. Also, I increased whole icon size. Can you please pull and retest? What state is on your last screenshot? If it is muted or deafened that means that icons too small, and we need to redraw them completely, because I just took discord's original icons and changed colors to Vesktop ones. They are 24x24 pixels, so maybe they have not resized to proper size in Gnome system.

I can confirm that it looks much better! Well, maybe the edges of the circle could be a little smoother but I believe that the pixels are due to my monitor. That's great :) thanks for accepting the feedbeck.

[Covkie]

Might it be best to fold #261 into this PR?

[D3SOX]

Why is it pink. I think this should either copy stock Discord or make it customizable. I would prefer the latter then I could select my accent color.
Not sure if it's feasible when it must be a PNG

[PolisanTheEasyNick]

Added ability to change colors. For now, I want to find a way how to disable icon color chooser in settings when tray icon is disabled instead of hiding the whole setting and (maybe) add ability to propose to user his system accent color.
Edit: also I want to slightly refactor code for not reapplying same color to svg on each state change but instead apply them once on color change, somewhere store pngs of needed color and just use them. Done

[kerriganx]

It is possible to add ability to set custom icon for unread messages instead of red dot? Thanks

[PolisanTheEasyNick]

Thank you for response!

You seem to have added a native dbus library. Do we really need this?

I'm using it for getting accent color from Linux system. The library was added because it may be used for some other features, like #686.
Personally, I think that feature "automatically pick accent color and propose it to user" is not very critical, because user can just pick color by himself, so I will remove library and accent color feature from this PR scope.

but remove the settings ui

Should I remain color picker settings?

[KarlOfDuty]

I do plan to have one central UI for managing various images but that should be part of a separate change

Is this planned soon? If its like a year away couldn't this gui be allowed to exist until then? It would be a shame to have these features ready to go but then get removed until really far into the future.

[fragtion]

3. I'm not really a fan of the customisations being baked into this PR. I do plan to have one central UI for managing various images but that should be part of a separate change, but the way you implemented it here doesn't really match what I had envisioned. Please remove the image customisation logic & ui. That will drastially reduce the complexity of this change

In other words, do keep all the tray modifiers like showing voice status, notification dot etc, but remove the settings ui

How should the icons now be modified now that the UI is removed? The default accent color is not striking/noticeable enough for me and I would like to be able to change it like we could earlier in this PR, but there seems to be no obvious way of doing that anymore...? Is this just a temporary regress?

[mrbigmouth502]

This branch is out-of-date with the base branch

Changes can be cleanly merged.

Hmm...

[Vendicated]

I just added tray customisation via #1179 so if you rebase on that, you can add customisation back!

Getting the system accent colour will be made possible via #1180 so then we can just use the user's system accent colour for the badge modifier colour

[mrbigmouth502]

I just wanna say thanks to whoever added tray notification badges recently. It's allowed me to finally switch over from the stock Discord client. 🙂

[PolisanTheEasyNick]

Hi @Vendicated,

I have updated branch to support newest master.
Currently this PR provides only support for voice tray icons.
Regarding changing badge color(s) according to system's accent color: it is possible, but wil greately overwhelm this PR, because images pre-processing should be done according to system accent color.
I think, that in scope of this PR it is okay to implement only tray icon voice detection, and, if needed - changing colors based on system accent in another PR.
But, I also think that it is not worth to do because of support of setting custom images for icons.
Waiting for a review and will be happy to fix issues.
TIA!