[VEN-3174]: ERC4626 wrapper for VToken contracts- Core Pool on BNB Chain#2
Open
Debugger022 wants to merge 43 commits intodevelopfrom
Open
[VEN-3174]: ERC4626 wrapper for VToken contracts- Core Pool on BNB Chain#2Debugger022 wants to merge 43 commits intodevelopfrom
Debugger022 wants to merge 43 commits intodevelopfrom
Conversation
Debugger022
changed the title
chechu
reviewed
Jun 25, 2025
chechu
reviewed
Jun 30, 2025
chechu
reviewed
Jun 30, 2025
chechu
reviewed
Jun 30, 2025
GitGuru7
reviewed
Jul 1, 2025
GitGuru7
reviewed
Jul 1, 2025
chechu
reviewed
Jul 2, 2025
chechu
reviewed
Jul 2, 2025
GitGuru7
previously approved these changes
Jul 3, 2025
web3rover
reviewed
Jul 15, 2025
| /// @title VenusERC4626Isolated | ||
| /// @notice ERC4626 wrapper for Venus Isolated Pool vTokens | ||
| contract VenusERC4626Isolated is VenusERC4626, MaxLoopsLimitHelper { | ||
| uint256 public constant LOOPS_LIMIT = 100; |
There was a problem hiding this comment.
In other contracts we pass this value in the initialiser. Maybe we can keep the standard.
GitGuru7
reviewed
Jul 23, 2025
chechu
reviewed
Jul 25, 2025
[VEN-3344]: Mitigations considering ERC4626
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #
Checklist