[VPD-1107]: Replace Token Converter docs with Phase 2 TokenBuyback#345
Open
Debugger022 wants to merge 2 commits intomainfrom
Open
[VPD-1107]: Replace Token Converter docs with Phase 2 TokenBuyback#345Debugger022 wants to merge 2 commits intomainfrom
Debugger022 wants to merge 2 commits intomainfrom
Conversation
|
GitBook Preview: https://docs-v4.venus.io/~/revisions/HNJY7DydbuX49HgHMZng/ |
- Fix line count (~170 → ~275) in Impact Summary to match the deployed TokenBuyback.sol - Say "5 contract classes across 8 deployed instances" so the intro stays consistent with the "Before (8)" table below - Describe forwardBaseAsset's `amount` parameter and its per-pool partitioning role instead of framing it as a generic no-swap forward - Disambiguate "Retired (burns)" → "Retired (was burn path)" so readers don't think WBNBBurnConverter still burns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the
whats-new/token-converter.mdpage with updated documentation for Token Converter Phase 2: TokenBuyback.The original page described the community-driven converter system. Phase 2 retires that system in favour of a single, lightweight
TokenBuybackcontract class deployed per (destination, base asset) pair, with conversions executed by an ACM-authorized finance-team cron job via DEX aggregators at market rate.Changes
TokenBuybacksolution and its key design decisionsupdateAssetsState,executeBuyback,forwardBaseAsset,setAllowedRouter,sweepTokenTokenBuybackinstances)RiskFundV2changes included in the migrationReferences