[VPD-1097]: add Phase1 Executor permission grant - BSC mainnet & Testnet#699
Open
Debugger022 wants to merge 2 commits intomainfrom
Open
[VPD-1097]: add Phase1 Executor permission grant - BSC mainnet & Testnet#699Debugger022 wants to merge 2 commits intomainfrom
Debugger022 wants to merge 2 commits intomainfrom
Conversation
Wires the Phase -1 Executor contract between off-chain signal monitors and EBrake. Grants monitor perms on Executor action handlers, Executor perms on EBrake, and Normal Timelock perm on setMarketConfig. Mainnet and testnet scaffolds with shared perm arrays imported from the VIP for single source of truth.
- `handleSupplyHalt` → `handleSupplyCapExceeding` (orphaned role: no such function on Executor) - `handleBorrowHalt` → `handleBorrowCapExceeding` (same) - `setMarketConfig` tuple: 6-field phantom → 3-field `(minBorrowCap, minSupplyCap, enabled)` matching IExecutor.MarketConfig - Broaden `setMarketConfig` grant from Normal-only to Guardian + all three timelocks
Debugger022
changed the title
Debugger022
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
VIP (vips/vip-701/)
bscmainnet.ts— grants signal monitor perms on 4 Executor handlers, Executor perms on 5 EBrake funcs, Normal Timelock perm onsetMarketConfigbsctestnet.ts— same layout, testnet ACM (0x45f8a08F) and EBrake (0x957c09e3)Simulations (simulations/vip-701/)
bscmainnet.ts— pre/post ACM permission checks, asserts 10 RoleGranted eventsbsctestnet.ts— mirror of mainnet simabi/AccessControlManager.json— copied from vip-610TODOs before proposal
EXECUTORaddress (deployment VIP must land first)SIGNAL_MONITORaddressBLOCK_NUMBERin both simssetMarketConfigtuple layout vs finalIExecutor.solTest plan
EXECUTOR/SIGNAL_MONITOR/BLOCK_NUMBERnpx hardhat test simulations/vip-701/bsctestnet.ts --fork bsctestnet— passesnpx hardhat test simulations/vip-701/bscmainnet.ts --fork bscmainnet