Open
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
|
We have been thinking about this a bit, and it might not be a bad idea after all. What we are thinking now is having a single alphabet, as before, but within that alphabet, there will be a vector of pointers to alphabets, one per tape. This will make the interface cleaner while allowing for per-tape alphabets. |
Author
|
Regarding this, a few comments/questions:
Expanding on 3.:
|
Collaborator
I am glad to hear that your thoughts about alphabets (as the sole extensive user of alphabets in Mata) are similar to what we came up with at the drawing board. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an option to have tape-specific alphabet pointers in an Nft.
The idea is that, if an optional vector of tape alphabet pointers is given, those are preferred when e.g. printing the Nft to dot format. A symbol is hence translated as determined by
nullopt, and there is a non-null pointer to some Alphabet at the current level), or otherwisemeaning the tape-specific alphabet (if existent) is preferred over the generic Nft alphabet.
Also, this PR includes some modifications to keep the specific and generic alphabets during some common constructions.