Bug fix: update levels in Nft::unite_nondet_with#614
Merged
Adda0 merged 1 commit intoVeriFIT:develfrom Mar 18, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #614 +/- ##
=======================================
Coverage 72.90% 72.91%
=======================================
Files 45 45
Lines 6795 6796 +1
Branches 1538 1538
=======================================
+ Hits 4954 4955 +1
Misses 1227 1227
Partials 614 614 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adda0
approved these changes
Mar 18, 2026
Collaborator
Adda0
left a comment
Adda0
left a comment
There was a problem hiding this comment.
LGTM. Thank you for the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
Nft::unite_nondet_withfunction insrc/nft/operations.cccopies the levels of the LHS transducer, but does not update them with the RHS levels. This leads to unexpected segfaults when trying to get the level of some state in the result which is part of the RHS nft.