Skip to content

Scope EF converters to Verify settings #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonCropp merged 1 commit into from
Jul 15, 2026
Merged

Scope EF converters to Verify settings #1031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ Recording is attached by `EnableRecording()`. Pass `recordCommands: false` to `I
```cs
VerifyEntityFramework.Initialize(data, recordCommands: false);
```
<sup><a href='/src/Verify.EntityFramework.RecordingDisabledTests/ModuleInitializer.cs#L10-L14' title='Snippet source file'>snippet source</a> | <a href='#snippet-DisableRecording' title='Start of snippet'>anchor</a></sup>
<sup><a href='/src/Verify.EntityFramework.RecordingDisabledTests/ModuleInitializer.cs#L8-L12' title='Snippet source file'>snippet source</a> | <a href='#snippet-DisableRecording' title='Start of snippet'>anchor</a></sup>
<!-- endSnippet -->

Only recording is disabled. The converters, and the queryable to SQL file converter, are still registered.
Expand Down
2 changes: 1 addition & 1 deletion src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Project>
<PropertyGroup>
<NoWarn>CS1591;CS0649;CS8632;EF1001;NU1608;NU1109</NoWarn>
<Version>15.3.0</Version>
<Version>15.3.1</Version>
<LangVersion>preview</LangVersion>
<AssemblyVersion>1.0.0</AssemblyVersion>
<PackageTags>EntityFramework, Verify</PackageTags>
Expand Down
10 changes: 5 additions & 5 deletions src/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,17 @@
<PackageVersion Include="Microsoft.SqlServer.TransactSql.ScriptDom" Version="180.37.3" />
<PackageVersion Include="NUnit" Version="4.6.1" />
<PackageVersion Include="NUnit3TestAdapter" Version="6.2.0" />
<PackageVersion Include="Polyfill" Version="10.11.2" />
<PackageVersion Include="Polyfill" Version="11.0.1" />
<PackageVersion Include="ProjectDefaults" Version="1.0.174" />
<PackageVersion Include="System.Data.SqlClient" Version="4.9.1" />
<PackageVersion Include="Verify" Version="31.24.1" />
<PackageVersion Include="Verify" Version="31.24.2" />
<PackageVersion Include="Verify.DiffPlex" Version="3.3.1" />
<PackageVersion Include="Verify.NUnit" Version="31.24.1" />
<PackageVersion Include="Verify.NUnit" Version="31.24.2" />
<PackageVersion Include="Verify.SqlServer" Version="12.2.0" />
<PackageVersion Include="Microsoft.Sbom.Targets" Version="4.1.5" />
<PackageVersion Include="Argon" Version="0.35.1" />
<PackageVersion Include="Argon" Version="0.35.2" />
<PackageVersion Include="DiffEngine" Version="19.3.2" />
<PackageVersion Include="EmptyFiles" Version="8.18.2" />
<PackageVersion Include="SimpleInfoName" Version="3.2.0" />
</ItemGroup>
</Project>
</Project>
2 changes: 0 additions & 2 deletions src/Verify.EntityFramework.RecordingDisabledTests/ModuleInitializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
using Microsoft.EntityFrameworkCore.Metadata;

public static class ModuleInitializer
{
[ModuleInitializer]
Expand Down
2 changes: 1 addition & 1 deletion src/Verify.EntityFramework/DescriptiveParameterNameGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ class DescriptiveParameterNameGenerator :
Dictionary<string, (int count, string entityName)> names = new(StringComparer.OrdinalIgnoreCase);

// All generated param names, for collision detection
HashSet<string> allGenerated = new(StringComparer.OrdinalIgnoreCase);
HashSet<string> allGenerated = [with(StringComparer.OrdinalIgnoreCase)];

string? pendingColumnName;
string? pendingEntityName;
Expand Down
14 changes: 9 additions & 5 deletions src/Verify.EntityFramework/VerifyEntityFramework.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,11 +144,15 @@ public static void Initialize(IModel? model, bool recordCommands)
(target, _) => QueryableConverter.IsQueryable(target));
VerifierSettings.IgnoreMembersWithType(typeof(IDbContextFactory<>));
VerifierSettings.IgnoreMembersWithType<DbContext>();
var converters = DefaultContractResolver.Converters;
converters.Add(new DbUpdateExceptionConverter());
converters.Add(new TrackerConverter());
converters.Add(new QueryableConverter());
converters.Add(new LogEntryConverter());

VerifierSettings.AddExtraSettings(settings =>
{
var converters = settings.Converters;
converters.Add(new DbUpdateExceptionConverter());
converters.Add(new TrackerConverter());
converters.Add(new QueryableConverter());
converters.Add(new LogEntryConverter());
});
}
static bool IsSqlServer(this IModel model)
{
Expand Down
Loading