Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/Verify.ExceptionParsing/Parser.cs
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ static Result InnerParse(IEnumerable<string> lines)

var firstLine = enumerator.Current!;
//MsTest exception start with "Test method..." so lets swallow them
if (firstLine.StartsWith("Test method"))
if (firstLine.StartsWith("Test method", StringComparison.Ordinal))
{
if (!enumerator.MoveNext())
{
Expand All @@ -62,30 +62,30 @@ static Result InnerParse(IEnumerable<string> lines)
continue;
}

if (line.StartsWith("FileContent:"))
if (line.StartsWith("FileContent:", StringComparison.Ordinal))
{
break;
}

if (line.StartsWith("New:"))
if (line.StartsWith("New:", StringComparison.Ordinal))
{
lineHandler = (next, scopedEnum) => AddFilePair(directory, next, scopedEnum, @new);
continue;
}

if (line.StartsWith("NotEqual:"))
if (line.StartsWith("NotEqual:", StringComparison.Ordinal))
{
lineHandler = (next, scopedEnum) => AddFilePair(directory, next, scopedEnum, notEqual);
continue;
}

if (line.StartsWith("Equal:"))
if (line.StartsWith("Equal:", StringComparison.Ordinal))
{
lineHandler = (next, scopedEnum) => AddFilePair(directory, next, scopedEnum, equal);
continue;
}

if (line.StartsWith("Delete:"))
if (line.StartsWith("Delete:", StringComparison.Ordinal))
{
lineHandler = (next, _) =>
{
Expand All @@ -112,7 +112,7 @@ static void ThrowIfEmpty(string directory)
}
}

if (firstLine.StartsWith("VerifyException : Directory: "))
if (firstLine.StartsWith("VerifyException : Directory: ", StringComparison.Ordinal))
{
var directory = firstLine[29..];

Expand All @@ -122,7 +122,7 @@ static void ThrowIfEmpty(string directory)
}

// MsTest
if (firstLine.StartsWith("VerifyException: Directory: "))
if (firstLine.StartsWith("VerifyException: Directory: ", StringComparison.Ordinal))
{
var directory = firstLine[28..];

Expand All @@ -131,7 +131,7 @@ static void ThrowIfEmpty(string directory)
return directory;
}

if (firstLine.StartsWith("Directory: "))
if (firstLine.StartsWith("Directory: ", StringComparison.Ordinal))
{
var directory = firstLine[11..];

Expand All @@ -145,7 +145,7 @@ static void ThrowIfEmpty(string directory)

static string TrimStart(string next, string prefix)
{
if (!next.StartsWith(prefix))
if (!next.StartsWith(prefix, StringComparison.Ordinal))
{
throw new ParseException($"Expected line to start with `{prefix}`. Line: {next}");
}
Expand Down
2 changes: 1 addition & 1 deletion src/Verify/ConventionCheck/InnerVerifyChecks.cs
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ static bool HasIndentExtension(List<string> extensions) =>

static bool HasAllExtensions(List<string> extensions, string[] lines)
{
var line = lines.FirstOrDefault(_ => _.StartsWith("[*.{received,verified}."));
var line = lines.FirstOrDefault(_ => _.StartsWith("[*.{received,verified}.", StringComparison.Ordinal));
if (line == null)
{
return false;
Expand Down
2 changes: 1 addition & 1 deletion src/Verify/VerifierSettings_PluginConvention.cs
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ static void ProcessFile(string file)
internal static bool TryGetType(string file, [NotNullWhen(true)] out Type? type)
{
var assemblyName = Path.GetFileNameWithoutExtension(file);
if (!assemblyName.StartsWith("Verify."))
if (!assemblyName.StartsWith("Verify.", StringComparison.Ordinal))
{
type = null;
return false;
Expand Down
Loading