Always run Java tests instead of letting Gradle skip them as up-to-date - #334
Merged
Conversation
The vibium binary and browser aren't Gradle inputs, so a cached test result meant make test-java reported green in under a second without executing a single test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gradle's up-to-date check skipped the :test task whenever Java sources and classpath were unchanged —
make test-javareported green in under a second with zero tests executed. The vibium binary and the browser aren't declared Gradle inputs, so even a fresh Go build wouldn't invalidate the cache.Fix:
outputs.upToDateWhen { false }on the test task, matching how the JS and Python suites always rerun. Compilation stays incremental.Verified locally:
make test-javanow runs 63 tests (0 failures, 1 skipped) in ~23s.