ci: deploy storybook on main push and build-check it on PRs#260
Merged
Conversation
The reusable storybook-ci.yml lost its caller when main.yml was removed during the release-automation refactor, so Storybook stopped building and deploying on pushes to main (release commits included). Nothing invoked the workflow anymore — it only ran on manual dispatch. Re-add the caller as a `storybook` job in ci.yml (push to main / feat/redesign, secrets inherited, no `release:` skip guard) so a release also redeploys Storybook. Add a build-only `storybook-build` job on pull_request that runs `yarn build` then `yarn build:storybook` with no Docker push or deploy, so a broken story fails review instead of surfacing after merge. Update the workflows README to match.
|
📦 Preview published for commit Install the preview with dist-tag: npm install @vc-shell/framework@pr-260Or pin to the exact commit: npm install @vc-shell/framework@2.2.0-pr260.a8bd3a7Published packages (dist-tag
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Storybook stopped building and deploying after the shell release. The reusable
storybook-ci.ymlis aworkflow_callworkflow with nopushtrigger of its own — it relied on a caller to invoke it. That caller lived inmain.yml, which was deleted during the release-automation refactor (5fb35c7f5, splitting intoci.yml+publish.yml). Neither replacement re-wired the Storybook invocation, so the workflow became orphaned and only ran on manualworkflow_dispatch.Result: pushes to
main(including the release commit) never rebuilt or redeployed Storybook. Thevc-shell-storybook.govirto.compreview went stale.Separately, Storybook was never built on PRs at all — no job runs
yarn build:storybookpre-merge, so a broken story (bad import, invalid syntax) passes every check and only fails after merge.Changes
ci.yml→storybookjob — re-adds the caller for the reusablestorybook-ci.ymlon push tomain/feat/redesign, withsecrets: inherit. It intentionally omits therelease:skip guard thestatic-checks/testjobs carry, so the release commit redeploys Storybook too.ci.yml→storybook-buildjob — PR-only, build-only validation:yarn build→yarn build:storybook, no Docker push, no ArgoCD deploy. Catches broken stories in review.README.md— updated the stale Storybook trigger description and documented both new jobs.Notes
storybook-buildcheck, not the full reusable workflow — the latter would push an image and deploy to the sharedvcmp-devenv, and every PR would clobber the others.secrets: inherit(vs the oldmain.ymlpassing onlyVCMP_PLATFORM_TOKEN) also makes the previously-emptyREPO_TOKEN/ Jira secrets available insidestorybook-ci.storybook-buildcheck runs on this very PR (workflow changes apply topull_requestfrom the head branch), so it doubles as live verification that Storybook builds.