Skip to content

Showcase: PipTrade Agent#70

Open
codedforum wants to merge 4 commits into
Virtual-Protocol:mainfrom
codedforum:pip-conversational-trader
Open

Showcase: PipTrade Agent#70
codedforum wants to merge 4 commits into
Virtual-Protocol:mainfrom
codedforum:pip-conversational-trader

Conversation

@codedforum

Copy link
Copy Markdown

Adds showcase/pip-conversational-trader.\n\nPipTrade Agent is a conversational trading agent in the Virtuals ecosystem, with two surfaces on the same self-custody wallet. In chat you type a trade in plain english and Pip quotes, safety checks, and executes it. On the /rh terminal you get market, limit, TWAP, and stop orders on any listed Robinhood Chain token. You keep your keys, settlement is private by default, and $PIP is a Virtuals token traded through the Virtuals bonding curve. Includes a live on-chain proof, an honest private by default writeup, the full command surface, and a poster. Manifest passes scripts/validate-showcase.mjs.

@celesteanglm celesteanglm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you for your contribution! The package validates cleanly, the public read endpoints are live, and the linked transaction is a successful VIRTUAL → PIP purchase.

Just some minor feedbacks:

  1. The current proof does not yet establish the repeated private by default / live product claims. The linked 34-second X demo ends with ‘coming to the main app this week’ and does not show settlement, while the transaction receipt is a public buy that sends VIRTUAL from, and returns PIP to, the same wallet. Could you add inspectable proof of the current live private/unlinkable settlement flow, or soften those claims to what the submitted proof shows?
  2. Nit: the poster resolves correctly, but it is 1200×630. The card image guide recommends a 16:9 image at 1280×720 or larger so it will not crop or look soft on the Showcase card.

Also left some smaller feedbacks on the PR itself.

{
"slug": "pip-conversational-trader",
"title": "PipTrade Agent",
"tagline": "Trade by chat or work the desk. Say it in plain english, or run market, limit, TWAP, and stop orders. You keep your keys, and it settles private by default.",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion to keep the tagline direct and aligned with the guide’s one-line, no-trailing-period convention!

Suggested change
"tagline": "Trade by chat or work the desk. Say it in plain english, or run market, limit, TWAP, and stop orders. You keep your keys, and it settles private by default.",
"tagline": "Trade by chat or work the desk with market, limit, TWAP, and stop orders while keeping custody",

"slug": "pip-conversational-trader",
"title": "PipTrade Agent",
"tagline": "Trade by chat or work the desk. Say it in plain english, or run market, limit, TWAP, and stop orders. You keep your keys, and it settles private by default.",
"description": "PipTrade Agent is a conversational trading agent in the Virtuals ecosystem, with two surfaces on the same self-custody wallet. In chat you type a trade the way you would say it, like buy 10 usd of PIP, or swap 2 usdc on base to sol and send it over, and Pip reads the intent, shows a live quote with price impact, minimum received, route, and a token safety read, then executes on your own wallet where you keep your keys. The same chat handles private sends, price, balance, a GO CAUTION BLOCK token safety check, price alerts, deposits from another chain, and a referral link. On the /rh terminal you get a full Robinhood Chain desk, trade any listed token with a honeypot and sell guard, quote transparency with a safety badge, and market, limit, TWAP, and stop orders run by a keeper, plus a private send. Settlement is private by default across both surfaces, so the on-chain link between your wallet and the destination is broken rather than left in the open, and $PIP itself is a Virtuals token traded through the Virtuals bonding curve. This entry ships a chat to trade readback with a live on-chain proof, an honest private by default writeup, and the full command surface across chat and the terminal.",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently six sentences; the guide asks for a plain-language 2–4 sentence description. Here’s a tighter version tied to the package’s submitted proof:

Suggested change
"description": "PipTrade Agent is a conversational trading agent in the Virtuals ecosystem, with two surfaces on the same self-custody wallet. In chat you type a trade the way you would say it, like buy 10 usd of PIP, or swap 2 usdc on base to sol and send it over, and Pip reads the intent, shows a live quote with price impact, minimum received, route, and a token safety read, then executes on your own wallet where you keep your keys. The same chat handles private sends, price, balance, a GO CAUTION BLOCK token safety check, price alerts, deposits from another chain, and a referral link. On the /rh terminal you get a full Robinhood Chain desk, trade any listed token with a honeypot and sell guard, quote transparency with a safety badge, and market, limit, TWAP, and stop orders run by a keeper, plus a private send. Settlement is private by default across both surfaces, so the on-chain link between your wallet and the destination is broken rather than left in the open, and $PIP itself is a Virtuals token traded through the Virtuals bonding curve. This entry ships a chat to trade readback with a live on-chain proof, an honest private by default writeup, and the full command surface across chat and the terminal.",
"description": "PipTrade Agent turns plain-English trading instructions into self-custody quotes and swaps, and its Robinhood Chain terminal supports market, limit, TWAP, and stop orders. The package includes live public market endpoints, a helper tool, and an on-chain PIP purchase receipt. It also documents the intended privacy boundary for swap and send settlement.",

Comment on lines +40 to +41
"token",
"acp"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn’t find a PipTrade provider or offering through acp browse using PipTrade Agent, PipTradeDex, or pip trade, and the package does not identify an ACP listing/job. The wallet/token transaction keeps this in showcase scope; let’s add acp only when there’s listing or job proof to link 😅

Suggested change
"token",
"acp"
"token"

"install": "cp -R showcase/pip-conversational-trader/skills/pip-trade-agent ~/.agents/skills/\ncp -R showcase/pip-conversational-trader/skills/pip-trade-agent ~/.claude/skills/"
}
],
"artifacts": [

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The video field guide asks linked videos to be listed under artifacts so they’re reachable from the project detail view 🙏

Suggested change
"artifacts": [
"artifacts": [
{
"label": "PipTrade conversational trading demo on X",
"href": "https://x.com/PipTradeDex/status/2078716840197378351",
"kind": "video"
},

@codedforum

Copy link
Copy Markdown
Author

Thank you for the thorough and helpful review. I have addressed all of it:

  1. acp removed. You are right that there is no ACP listing yet, so it should not be claimed. I am standing up a real token-safety offering and will add acp back only once Pip is discoverable in acp browse.

  2. Private by default proof rebuilt with three real settlements and on-chain links, reframed honestly as unlinkability and not zero knowledge. The clearest is a base to base swap where the receive arrives from a different counterparty than the send:
    send https://basescan.org/tx/0xaf00110622fa7ff93b9cb2c7ef2655c775d95814b84e1a2c01bea4ef0410377d
    private receive https://basescan.org/tx/0x2821db35ab0f66ed898a10a8ce5c28f12994cedc3edbb2163d86d9ad217d62ee
    Plus a cross-chain base to sol swap and a base to base ETH to USDC one, all in examples/private-by-default.md.

  3. Tagline is now one line with no trailing period, and the description is three sentences tied to the proof.

  4. The demo video is also listed under artifacts.

  5. Poster re-rendered at 1280x720.

Thanks again, happy to adjust anything else.

@LauJoeYing LauJoeYing left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @codedforum, great work addressing the earlier feedbacks

One thing before merge: posterUrl in showcase.json points at your fork branch instead of Virtual-Protocol/acp-cli-demos/main/.... It resolves now, but will break once your fork/branch gets cleaned up after merge. Could you update it to:

https://raw.githubusercontent.com/Virtual-Protocol/acp-cli-demos/main/showcase/pip-conversational-trader/assets/poster.png

A few other links (links.repo, links.demo, artifacts hrefs, skills[].href, soul.href) point at your fork too, worth repointing those at main as well for the same reason.

Good to go once that's fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants