showcase:Pangs Rally#74
Open
pangsdev wants to merge 6 commits into
Open
Conversation
LauJoeYing
requested changes
Jul 23, 2026
LauJoeYing
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the submission! Before this can be merged, the hero card needs some fixes in showcase.json:
-
posterUrl is empty (""). there's no image asset in the PR for now. Could you add a poster/screenshot (include assets/poster.jpg) and point posterUrl at it?
-
No videoUrl, the visual block has a videoLabel ("Watch the gameplay demo on X") but nothing to actually play. links.video points to an X/Twitter status page, which won't embed as a playable video. Could you either:
- link directly to a hosted video file (e.g. an .mp4), or
- clarify how this should render if a tweet link is all that's available?
artifacts is empty consider adding at least a proof/demo link here so reviewers have something to click into.
Author
|
I've uploaded the hosted video (.mp4) and poster (.png) directly to the assets folder as suggested, and updated the showcase.json with the correct URLs and artifacts. Thanks for the guidance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Showcase Project
What shipped
Project package
showcase/pangs-rally/showcase.jsonshowcase/<project-slug>/skills/<skill-name>/when it belongs to this project packageskills/<skill-name>/only when the skill is shared across projectsskills[].sourcePathinshowcase.jsonfor any skill committed in this repo