Conversation
dkmstr
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily removes excessive or redundant debug and info logging from the RDP transport scripts for Linux and macOS, making the code cleaner and reducing unnecessary log output. At the same time, it improves the usefulness of remaining logs by adding targeted debug/error messages for executable discovery and error cases.
Logging cleanup and improvements:
Removed unnecessary debug and info logging statements from RDP file preparation and client execution in
direct.pyandtunnel.pyfor both Linux and macOS, reducing log noise and focusing logs on relevant events. [1] [2] [3] [4] [5] [6] [7] [8] [9]Added targeted debug and error logging for the discovery and selection of RDP clients (Thincast, UDSRDP, XFREERDP) on Linux and macOS, making it easier to diagnose client selection issues. [1] [2]
Code comments and documentation:
direct.py.Signature updates:
.signaturefiles to reflect changes in the corresponding Python scripts. [1] [2] [3] [4]