Switches server import to parse CSV string input#158
Closed
aschumann-virtualcable wants to merge 1 commit intov4.0from
Closed
Switches server import to parse CSV string input#158aschumann-virtualcable wants to merge 1 commit intov4.0from
aschumann-virtualcable wants to merge 1 commit intov4.0from
Conversation
Updates the import logic to accept a CSV-formatted string instead of a JSON array, improving compatibility and aligning with common data exchange formats. Enhances input handling by leveraging the CSV parser for more robust processing and easier integration.
Contributor
Author
|
Other changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
importcsvmethod inservers_management.pyto change how CSV data is processed for server group imports. Instead of expecting a JSON array of arrays, the method now expects a single CSV string, and uses Python'scsvmodule for parsing. This improves compatibility with standard CSV formats and simplifies input handling.CSV Import Refactor:
importcsvmethod to accept a CSV string instead of a JSON array of arrays, aligning with standard CSV handling practices.csvmodule andio.StringIOto parse the CSV string, replacing manual iteration over a list of lists. [1] [2]Code Cleanup:
.strip()calls on parsed CSV fields, as thecsvreader already handles whitespace appropriately, and simplified MAC address normalization.[Copilot is generating a summary...]