Skip to content

Refactors Proxmox services to unify service type and storage logic#159

Merged
dkmstr merged 1 commit intov4.0from
dev/andres/v4.0-proxmox-lvm
Mar 18, 2026
Merged

Refactors Proxmox services to unify service type and storage logic#159
dkmstr merged 1 commit intov4.0from
dev/andres/v4.0-proxmox-lvm

Conversation

@aschumann-virtualcable
Copy link
Contributor

This pull request introduces several improvements and refactors to the Proxmox service integration. The most significant changes are focused on updating type references for service classes, improving storage listing and filtering, and enhancing console connection functionality. There are also minor updates to copyright statements and some code cleanup.

Refactoring and Type Updates

  • Updated type references throughout the Proxmox service code to use ProxmoxService instead of ProxmoxServiceLinked, including in deployment_linked.py and provider.py, and changed the offers list in ProxmoxProvider accordingly. [1] [2] [3] [4]
  • Removed the unused import of UserServiceManager and the now-unused desktop_login method from deployment_linked.py, simplifying the codebase. [1] [2]

Storage Listing and Filtering Improvements

  • Modified the storage listing logic in helpers.py to no longer skip certain storage types (lvm, iscsi, iscsidirect), allowing for more comprehensive storage selection.
  • Enhanced the list_storages method in client.py to pass the Proxmox version to StorageInfo.from_dict, improving compatibility and filtering.

Console Connection Enhancements

  • Added a get_console_connection method to deployment_fixed.py to provide console connection info via the service, improving remote access capabilities.

Validation and Initialization

  • Added MAC range validation in the initialize method of ProxmoxProvider, ensuring proper configuration of provider settings.

Miscellaneous and Code Cleanup

Consolidates linked clone service implementation by removing redundant code and references, streamlining type hints and imports to use a single service class.

Enhances storage selection logic to support snapshot capabilities based on Proxmox version, ensuring compatibility and correctness for linked clones.

Improves timestamp handling with timezone awareness for better reliability.

Addresses copyright formatting and minor code cleanups for clarity and maintainability.
@dkmstr dkmstr merged commit be00147 into v4.0 Mar 18, 2026
2 checks passed
@aschumann-virtualcable aschumann-virtualcable deleted the dev/andres/v4.0-proxmox-lvm branch March 18, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants