Refactors Proxmox services to unify service type and storage logic#159
Merged
Refactors Proxmox services to unify service type and storage logic#159
Conversation
Consolidates linked clone service implementation by removing redundant code and references, streamlining type hints and imports to use a single service class. Enhances storage selection logic to support snapshot capabilities based on Proxmox version, ensuring compatibility and correctness for linked clones. Improves timestamp handling with timezone awareness for better reliability. Addresses copyright formatting and minor code cleanups for clarity and maintainability.
dkmstr
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactors to the Proxmox service integration. The most significant changes are focused on updating type references for service classes, improving storage listing and filtering, and enhancing console connection functionality. There are also minor updates to copyright statements and some code cleanup.
Refactoring and Type Updates
ProxmoxServiceinstead ofProxmoxServiceLinked, including indeployment_linked.pyandprovider.py, and changed theofferslist inProxmoxProvideraccordingly. [1] [2] [3] [4]UserServiceManagerand the now-unuseddesktop_loginmethod fromdeployment_linked.py, simplifying the codebase. [1] [2]Storage Listing and Filtering Improvements
helpers.pyto no longer skip certain storage types (lvm,iscsi,iscsidirect), allowing for more comprehensive storage selection.list_storagesmethod inclient.pyto pass the Proxmox version toStorageInfo.from_dict, improving compatibility and filtering.Console Connection Enhancements
get_console_connectionmethod todeployment_fixed.pyto provide console connection info via the service, improving remote access capabilities.Validation and Initialization
initializemethod ofProxmoxProvider, ensuring proper configuration of provider settings.Miscellaneous and Code Cleanup
clone_vmand additional whitespace for readability. [1] [2] [3] [4] [5]