Adds snapshot creation and recovery support for linked and full VMs#25
Merged
Adds snapshot creation and recovery support for linked and full VMs#25
Conversation
Introduces methods to handle VM snapshot creation and restoration, enabling improved backup and recovery workflows. Refactors type hints for better clarity and modern Python usage. Enhances test setup to ensure consistent provider injection. Improves clone validation logic to correctly handle linked clone requirements and storage capabilities.
dkmstr
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements and fixes across the Proxmox service implementation and its test suite. The most significant changes include enhancements to snapshot management, stricter validation for clone types, improved test fixture consistency, and modernization of type annotations.
Enhancements to Proxmox service functionality:
snapshot_creationandsnapshot_recoverymethods toProxmoxServicefor automatic snapshot management, including background snapshot creation and recovery for linked user services.initializeto correctly check storage support for linked clones and raise errors when unsupported clone types are requested.Test suite improvements and fixture consistency:
Modernization and code cleanup:
list[...],dict[...],str | None) and replacedtypingwithcollections.abcwhere appropriate. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Exception handling improvements:
Logging improvements:
These changes collectively improve the robustness, maintainability, and clarity of the Proxmox service codebase and its associated tests.