Dev/andres/master favorite services changes#27
Merged
Conversation
Updates modern frontend dependencies and UI layout Refreshes polyfills and scripts to improve compatibility. Refactors main JavaScript logic and streamlines translations. Adjusts styles and HTML structure for enhanced consistency and maintainability across the modern user interface.
dkmstr
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Favoriting a service pool was silently ignored when the user had never used that service (i.e., no associated
UserService). Theactionview attempted to resolve aUserServicefirst and only proceeded if it existed. For services within_use: false, noUserServiceis created, so the favorite action was never executed. The request still returned HTTP 200 with an empty body, resulting in no visible feedback on the frontend.Root cause
The favorite/unfavorite logic was incorrectly dependent on the existence of a
UserService, even though this operation only requires the service pool identifier.Fix
Refactored
uds/web/views/service.py(actionfunction) to handlefavoriteandunfavoriteactions before attempting to resolve aUserService.service_id(F<uuid>/M<uuid>).request.user.add_favorite()/remove_favorite()immediately.UserService.Removed the duplicated favorite/unfavorite handling that previously occurred after the
UserServicelookup.Why it worked for in-use services
When a service was already in use, a
UserServiceexisted, so the lookup succeeded and the favorite was applied usinguserservice.service_pool.uuid. For unused services, the lookup returnedNone, causing the logic to be skipped entirely.Additional changes
Translations and UI text
translations-fakejs.js.Code cleanup