Skip to content

Refactors RDP tunnel logic to streamline and unify handling#29

Open
aschumann-virtualcable wants to merge 1 commit intomasterfrom
dev/andres/master-rdp-rdpembedded-for-tunnel.js
Open

Refactors RDP tunnel logic to streamline and unify handling#29
aschumann-virtualcable wants to merge 1 commit intomasterfrom
dev/andres/master-rdp-rdpembedded-for-tunnel.js

Conversation

@aschumann-virtualcable
Copy link
Contributor

This pull request refactors and simplifies the Linux tunnel scripts for both the RDP and RDPEmbedded transports. The main focus is on improving tunnel initialization, streamlining client launching logic, and updating the process for starting tunnels and handling RDP connections. Significant cleanup removes redundant code and aligns parameter naming conventions for better maintainability.

RDP tunnel script improvements:

  • Changed the order of searching for RDP client executables to prefer xfreerdp2 before xfreerdp, ensuring compatibility with newer versions.
  • Updated the Tasks.startTunnel invocation to use a single object parameter with clearer, more descriptive field names (addr, port, ticket, startup_time_ms, check_certificate, shared_secret), improving readability and maintainability.

RDPEmbedded tunnel script simplification:

  • Removed all logic related to finding and launching local RDP client executables, as well as handling temporary RDP files and parameter expansion. Now, the script simply starts the tunnel and invokes RDP.start(data), delegating connection handling to a uds launcher rdp embedded.
  • Updated logging to provide clearer information about tunnel establishment and removed unnecessary error messages about missing RDP clients.

Signature updates:

  • Updated the signature files for both tunnel scripts to reflect the code changes. [1] [2]

Simplifies and unifies RDP tunnel setup by reworking parameters,
removing manual client discovery and launch logic, and delegating
connection startup to a shared runtime method. Improves maintainability
and future extensibility by centralizing tunnel initiation and reducing
duplicate code paths.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants