Refactors RDP tunnel logic to streamline and unify handling#29
Open
aschumann-virtualcable wants to merge 1 commit intomasterfrom
Open
Refactors RDP tunnel logic to streamline and unify handling#29aschumann-virtualcable wants to merge 1 commit intomasterfrom
aschumann-virtualcable wants to merge 1 commit intomasterfrom
Conversation
Simplifies and unifies RDP tunnel setup by reworking parameters, removing manual client discovery and launch logic, and delegating connection startup to a shared runtime method. Improves maintainability and future extensibility by centralizing tunnel initiation and reducing duplicate code paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and simplifies the Linux tunnel scripts for both the RDP and RDPEmbedded transports. The main focus is on improving tunnel initialization, streamlining client launching logic, and updating the process for starting tunnels and handling RDP connections. Significant cleanup removes redundant code and aligns parameter naming conventions for better maintainability.
RDP tunnel script improvements:
xfreerdp2beforexfreerdp, ensuring compatibility with newer versions.Tasks.startTunnelinvocation to use a single object parameter with clearer, more descriptive field names (addr,port,ticket,startup_time_ms,check_certificate,shared_secret), improving readability and maintainability.RDPEmbedded tunnel script simplification:
RDP.start(data), delegating connection handling to a uds launcher rdp embedded.Signature updates: