Skip to content

Unpinning openpyxl to ^3.1.5#145

Merged
alightwing merged 1 commit into
VisualMeaning:masterfrom
AchilleSalaun:unpin_openpyxl
Jun 16, 2025
Merged

Unpinning openpyxl to ^3.1.5#145
alightwing merged 1 commit into
VisualMeaning:masterfrom
AchilleSalaun:unpin_openpyxl

Conversation

@AchilleSalaun
Copy link
Copy Markdown
Contributor

@AchilleSalaun AchilleSalaun commented Jun 16, 2025

openpyxl has been pinned in sheet-to-triples because of a bug. This bug seems to be no longer active.
This PR proposes to release openpyxl's version to '^3.1.5'.

Verifying the bug:

  • In an Excel export file, format a sheet as a table
  • Activate dynamic filters
  • Save
  • Run the corresponding job file (upload_commands from illustrator-to-smp)

Review requested from: @VisualMeaning/devs
JIRA Ticket: SMP-3267

Copy link
Copy Markdown
Contributor

@alightwing alightwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug in question should have been resolved by https://foss.heptapod.net/openpyxl/openpyxl/-/merge_requests/425, which was merged in over a year ago - we pinned as it was stuck in review hell at the time. Pinning should no longer be necessary.

Thanks!

@AchilleSalaun AchilleSalaun reopened this Jun 16, 2025
@alightwing alightwing merged commit 6a38e66 into VisualMeaning:master Jun 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants