Open
Conversation
On ProMotion displays (MacBook Pro 14"/16"), MTKView renders at 120 FPS by default. For UI rendering this doubles GPU usage with no visible benefit — UI elements don't need to update faster than 60 Hz. This is especially relevant for audio plugins where GPU resources are shared with the host application and other plugins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On ProMotion displays (MacBook Pro 14"/16"), MTKView defaults to 120 FPS. For UI rendering this doubles GPU usage with no visible benefit — (at least in my current use cases) UI elements don't need to update faster than 60 Hz.
This is especially noticeable for audio plugins where GPU resources are shared with the host application and other plugins running simultaneously.
I presume there are use cases that benefit from higher frame rates, maybe this could be made configurable instead. Happy to adjust the approach.
Discovered while working on a macOS JUCE audio plugin that uses Visage for its UI. This PR was put together with the help of Claude. Completely understand if you'd prefer to close this — just wanted to share the fix since we've been patching around it on our end whenever we update Visage.