Skip to content

Account verification process#9

Open
nikolasp wants to merge 1 commit into
masterfrom
account-verification
Open

Account verification process#9
nikolasp wants to merge 1 commit into
masterfrom
account-verification

Conversation

@nikolasp

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread requirements/dev.txt
ipdb==0.13.3
flake8==3.8.3
yapf==0.30.0
django-extensions==3.1.1

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added as dev dependency
./manage.py show_urls is quite useful

Comment thread src/users/views.py
@action(detail=False, methods=['get'], url_path='verify', url_name='verify_account')
def verify_account(self, request):
token = request.query_params.get('token') or ''
valid, user = default_token_generator.check_token(token)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe throw exception from token generator if it's invalid

@julioriffel julioriffel left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants