Skip to content

mdnsd.c: fix conflict detection to filter out all assigned IP addresses#1

Merged
thom-nic merged 2 commits intomasterfrom
tmn-82-conflict-detection-multiple-addresses
Mar 4, 2026
Merged

mdnsd.c: fix conflict detection to filter out all assigned IP addresses#1
thom-nic merged 2 commits intomasterfrom
tmn-82-conflict-detection-multiple-addresses

Conversation

@thom-nic
Copy link
Copy Markdown

@thom-nic thom-nic self-assigned this Jan 13, 2026
@thom-nic thom-nic force-pushed the tmn-82-conflict-detection-multiple-addresses branch 3 times, most recently from 033d2c4 to 73bcfe3 Compare January 13, 2026 22:48
@thom-nic thom-nic force-pushed the tmn-82-conflict-detection-multiple-addresses branch from 73bcfe3 to a68630a Compare January 13, 2026 23:12
Copy link
Copy Markdown

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@thom-nic
Copy link
Copy Markdown
Author

thom-nic commented Mar 2, 2026

Hi @troglobit thanks for looking at this. This PR is a mirror of troglobit#88 which I had opened here in case I needed to start maintaining a divergent fork of the official repo.

What do you think of this versus #3 ? The caching behavior won't cause false positives (conflicts) due to the forced-refresh behavior. But could result in false negatives, I think: incorrectly treating the address as local, and not treating it as a conflict. This could occur if the host released an address and then received a packet from that address which was then ignored, before the cache was refreshed.

@troglobit
Copy link
Copy Markdown

Hi @troglobit thanks for looking at this. This PR is a mirror of troglobit#88 which I had opened here in case I needed to start maintaining a divergent fork of the official repo.

Aha, LOL! In my sleep deprived state I didn't understand why I couldn't merge this 😄

What do you think of this versus #3 ? The caching behavior won't cause false positives (conflicts) due to the forced-refresh behavior. But could result in false negatives, I think: incorrectly treating the address as local, and not treating it as a conflict. This could occur if the host released an address and then received a packet from that address which was then ignored, before the cache was refreshed.

I think this cached version is the way to go, definitely.

@thom-nic thom-nic merged commit d613f80 into master Mar 4, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

conflicting name detected

2 participants