fix(character): rankings tab shows curated bosses only + expansion dropdown - #191
Merged
Conversation
…opdown The tab was surfacing every heuristic-matched named (any capitalised mob title) the character ever logged. Now gated to the curated zones.db universe - the exact set the rankings page dropdowns show. Uncurated kills are dropped entirely: no boss rows, no percentile-pool or All Stars pollution, and an all-uncurated character keeps the tab hidden. Zone sections carry their zones.db expansion tag and the response lists the expansions the character has ranked kills in (newest first); the tab adds an expansion dropdown next to the metric toggle, defaulting to the newest, filtering client-side. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #190 (user feedback: "it's showing every conceivable boss").
expansiontag; the response lists the expansions the character has ranked kills in (newest first — currently that can only be EoF/RoK, matching the curated raid section). The tab adds an expansion dropdown next to the Damage/Healing toggle, defaulting to the newest, filtering client-side with no refetch.Test plan
zones: []), fixture now patches the curated-tree seam. 8/8 green, full suite 1638.EoF, only its 4 curated bosses returned.🤖 Generated with Claude Code