fix(l10n): New translations#736
Closed
wfcd-bot-boi wants to merge 24 commits intomasterfrom
Closed
Conversation
📝 WalkthroughWalkthroughAdded Send Feedback and Inventoria onboarding localization entries and standardized the "legalese" string to an English affiliation/trademark statement across twelve ARB locale files. Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@lib/l10n/arb/intl_cs.arb`:
- Around line 1328-1354: The added localization entries (sendFeedbackTitle,
sendFeedbackDescription, sendFeedbackLabelText, sendFeedbackHintText,
sendFeedbackHelperText, sendFeedbackSubmissionSuccessful,
sendFeedbackSubmissionFailure) are still in English; replace each value with the
correct Czech translation for the UI (e.g., translate "Send Feedback", "Help us
improve Navis! Share your thoughts, report bugs, or suggest new features.",
"Email (optional)", hint text, helper text, and submission success/failure
messages) so the arb values for these keys are fully localized into Czech while
keeping the existing description metadata intact.
In `@lib/l10n/arb/intl_ru.arb`:
- Around line 1328-1354: The RU locale file contains untranslated English
strings for the send-feedback feature; update the keys sendFeedbackTitle,
sendFeedbackDescription, sendFeedbackLabelText, sendFeedbackHintText,
sendFeedbackHelperText, sendFeedbackSubmissionSuccessful, and
sendFeedbackSubmissionFailure in intl_ru.arb with proper Russian translations
(or explicitly mark them as intentional English fallback if that is desired),
ensuring each translated value preserves the corresponding metadata entries (the
"@..." description objects) unchanged.
♻️ Duplicate comments (10)
lib/l10n/arb/intl_de.arb (1)
1328-1354: Same localization note as intl_ru.arb.
Send‑Feedback strings remain English; please translate or confirm fallback.lib/l10n/arb/intl_pl.arb (1)
1328-1354: Same localization note as intl_ru.arb.
Send‑Feedback strings remain English; please translate or confirm fallback.lib/l10n/arb/intl_sr.arb (1)
1328-1354: Same localization note as intl_ru.arb.
Send‑Feedback strings remain English; please translate or confirm fallback.lib/l10n/arb/intl_tr.arb (1)
1328-1354: Same localization note as intl_ru.arb.
Send‑Feedback strings remain English; please translate or confirm fallback.lib/l10n/arb/intl_ko.arb (1)
1328-1354: Same localization note as intl_ru.arb.
Send‑Feedback strings remain English; please translate or confirm fallback.lib/l10n/arb/intl_fr.arb (1)
1328-1354: Same localization concern as intl_cs: feedback strings are English.
Please confirm this is intentional for French or provide translations.lib/l10n/arb/intl_es.arb (1)
1328-1354: Same localization concern as intl_cs: feedback strings are English.
Please confirm this is intentional for Spanish or provide translations.lib/l10n/arb/intl_pt.arb (1)
1328-1354: Same localization concern as intl_cs: feedback strings are English.
Please confirm this is intentional for Portuguese or provide translations.lib/l10n/arb/intl_it.arb (1)
1328-1354: Same localization concern as intl_cs: feedback strings are English.
Please confirm this is intentional for Italian or provide translations.lib/l10n/arb/intl_zh.arb (1)
1328-1354: Same localization concern as intl_cs: feedback strings are English.
Please confirm this is intentional for Chinese or provide translations.
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Fix all issues with AI agents
In `@lib/l10n/arb/intl_de.arb`:
- Around line 1328-1398: The ARB entries (sendFeedbackTitle,
sendFeedbackDescription, sendFeedbackLabelText, sendFeedbackHintText,
sendFeedbackHelperText, sendFeedbackSubmissionSuccessful,
sendFeedbackSubmissionFailure, inventoriaStepOneTitle, inventoriaStepOne,
inventoriaStepTwoTitle, inventoriaStepTwoDescription, inventoriaStepThreeTitle,
inventoriaStepThreeDescription, inventoriaStepThreeButtonLabel,
inventoriaStepThreeTextLabel, inventoriaStepFourTitle) are still in English;
replace each English value with accurate German translations (keeping
placeholders {faqLink}, {discordLink} intact and preserving the JSON/ARB
structure and descriptions) so the de locale is fully localized.
In `@lib/l10n/arb/intl_es.arb`:
- Around line 1327-1398: The new localization entries (e.g., sendFeedbackTitle,
sendFeedbackDescription, sendFeedbackLabelText, sendFeedbackHintText,
sendFeedbackHelperText, sendFeedbackSubmissionSuccessful,
sendFeedbackSubmissionFailure, inventoriaStepOneTitle, inventoriaStepOne,
inventoriaStepTwoTitle, inventoriaStepTwoDescription, inventoriaStepThreeTitle,
inventoriaStepThreeDescription, inventoriaStepThreeButtonLabel,
inventoriaStepThreeTextLabel, inventoriaStepFourTitle) are currently English in
the Spanish ARB; either replace each string with the correct Spanish translation
or mark them as intentionally untranslated (e.g., add a comment/metadata or
flag) so reviewers know this is deliberate before merging. Ensure the
placeholders in inventoriaStepOne remain intact when translating.
In `@lib/l10n/arb/intl_fr.arb`:
- Around line 1328-1398: The French ARB contains English text for several keys;
translate their values into French so the fr locale is fully localized. Update
the string values for keys: sendFeedbackTitle, sendFeedbackDescription,
sendFeedbackLabelText, sendFeedbackHintText, sendFeedbackHelperText,
sendFeedbackSubmissionSuccessful, sendFeedbackSubmissionFailure and all
inventoria* keys (inventoriaStepOneTitle, inventoriaStepOne,
inventoriaStepTwoTitle, inventoriaStepTwoDescription, inventoriaStepThreeTitle,
inventoriaStepThreeDescription, inventoriaStepThreeButtonLabel,
inventoriaStepThreeTextLabel, inventoriaStepFourTitle) replacing the English
sentences with proper French translations while keeping placeholders (e.g.,
{faqLink}, {discordLink}) intact and not altering the corresponding metadata
objects.
In `@lib/l10n/arb/intl_it.arb`:
- Around line 1328-1398: The Italian ARB file contains English strings for the
new Send Feedback and Inventoria keys (e.g., sendFeedbackTitle,
sendFeedbackDescription, sendFeedbackLabelText, sendFeedbackHintText,
sendFeedbackHelperText, sendFeedbackSubmissionSuccessful,
sendFeedbackSubmissionFailure, inventoriaStepOneTitle, inventoriaStepOne,
inventoriaStepTwoTitle, inventoriaStepTwoDescription, inventoriaStepThreeTitle,
inventoriaStepThreeDescription, inventoriaStepThreeButtonLabel,
inventoriaStepThreeTextLabel, inventoriaStepFourTitle); replace the English
values with proper Italian translations for each of these keys in
lib/l10n/arb/intl_it.arb so the Italian locale shows fully localized text
(preserve the metadata objects like "@..."/placeholders exactly as-is).
In `@lib/l10n/arb/intl_pt.arb`:
- Around line 1328-1398: The Portuguese ARB contains English strings (e.g.,
sendFeedbackTitle, sendFeedbackDescription, sendFeedbackLabelText,
sendFeedbackHintText, sendFeedbackHelperText, sendFeedbackSubmissionSuccessful,
sendFeedbackSubmissionFailure, inventoriaStepOneTitle, inventoriaStepOne,
inventoriaStepTwoTitle, inventoriaStepTwoDescription, inventoriaStepThreeTitle,
inventoriaStepThreeDescription, inventoriaStepThreeButtonLabel,
inventoriaStepThreeTextLabel, inventoriaStepFourTitle) — replace each English
value with accurate Portuguese translations while preserving the JSON keys,
descriptions, and any placeholders (like {faqLink}, {discordLink}) and their
types; ensure pluralization/escape sequences and newline formatting in
inventoriaStepOne remain intact and update any tooltip/description text if
needed so the pt ARB contains fully localized strings rather than English
fallbacks.
In `@lib/l10n/arb/intl_tr.arb`:
- Around line 1328-1398: The ARB entries for the Send Feedback and Inventoria
flows (keys like "sendFeedbackTitle", "sendFeedbackDescription",
"sendFeedbackLabelText", "sendFeedbackHintText", "sendFeedbackHelperText",
"sendFeedbackSubmissionSuccessful", "sendFeedbackSubmissionFailure", and
inventoria keys such as "inventoriaStepOne", "inventoriaStepOneTitle",
"inventoriaStepTwoTitle", "inventoriaStepTwoDescription",
"inventoriaStepThreeTitle", "inventoriaStepThreeDescription",
"inventoriaStepThreeButtonLabel", "inventoriaStepThreeTextLabel",
"inventoriaStepFourTitle") are still in English; translate each string value
into Turkish preserving the keys and placeholder structure (e.g., keep
"{faqLink}" and "{discordLink}" and the "placeholders" block unchanged) and
update the corresponding "@..." description objects only if needed; ensure
translations are natural, respect punctuation/newlines, and do not alter JSON
formatting or key names.
SlayerOrnstein
approved these changes
Mar 2, 2026
Member
|
@coderabbitai resolve |
✅ Actions performedComments resolved. Auto-approval is disabled; enable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Updates
✏️ Tip: You can customize this high-level summary in your review settings.