Conversation
310c9cb to
ad92376
Compare
Contributor
Author
|
Had a quick search on GitHub and all that came up were forks of GridVisualize or completely unrelated projects when it comes to MakieType. |
Member
|
I think formally this would be a breaking change which by semver increases the major version number and we very much should try to stick to this. I would put this on a list with other possibly breaking changes, which together would be substantial enough to be worth a najor release. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As proposed in #108 this changes dispatch.jl to use Singletons instead of using the set of nested ifs in
plottertypewith ismakie() and similar.Since
MakieTypewas heuristic based I had to introduce the alternativeAbstractMakieTypeand change the Makie extension accordingly by addingwhere {MakieType <: AbstractMakieType}where needed.Then all tests ran locally without problem.
Now, extending GridVisualize with another plotting backend can be done without needing to touch the main package.
Nevertheless, introducing a new shorthand through
const AnotherPlotterPackageType = PlotterType{:AnotherPlotterPackage}is certainly nice and quickly done.
@j-fu do you know of any downstream package that might explicitly use
MakieType?And if you are fine with this we should test the alternative to the example to remove the !private! functions ismakie and similar.