fix(auth): preserve legacy student accounts with Google#24
Draft
WILLIAMMDN wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qu? cambia
google.com;jose123 / 1234como credencial can?nica de QA.Causa ra?z
El proceso Laravel que llevaba horas escuchando en
localhost:8000hab?a heredado una configuraci?n anterior. Aunque la CLI actual ve?a Supabase yFIREBASE_PROJECT_ID=daemon-a41f8, ese proceso consultaba otro estado y respond?a422tanto parajose123como para Firebase. Adem?s, una cuenta legacy sin email o Firebase UID no pod?a vincularse a Google de forma segura.Impacto
El acceso local tradicional vuelve a funcionar despu?s de reiniciar el backend con el entorno actual. Cuando este PR se integre, un alumno podr? asociar Google a su cuenta anterior sin perder datos y sin riesgo de vinculaci?n por simple coincidencia de nombre.
Validaci?n
php artisan test: 141 pruebas, 499 asercionesnpm run test:ci: 39 pruebasnpm run build: bundle inicial 919.89 kBjose123 / 1234devuelve 200/alumnoy carga de XP, DAEMONS y ranking correctos