Support for Live photos, windows tests, supplemental-metadata fixes - #17
Open
trmfreitas wants to merge 20 commits into
Open
Support for Live photos, windows tests, supplemental-metadata fixes#17trmfreitas wants to merge 20 commits into
trmfreitas wants to merge 20 commits into
Conversation
trmfreitas
commented
May 6, 2025
trmfreitas
commented
- Better suffix removal by correctly evaluating situations where replica counter is included in image name like (img(1)).
- Dependencies upgraded
- Windows tests corrections
- Added new test cases
- Support by live photos by moving the .MP4 and applying the date from the .json for the corresponding image
refs [Wacheee#15](Wacheee#15) recovered tests on windows and added test for rename json with supplemental metadata
refs [[Wacheee#15] Fixed problem with files that only have the supplemental as .s.... by checking if the json format is already good and a corresponding file already exists Cached directory list on jsonForFile for speeding up process
…counter Fix supplemental metadata with counter
refs Wacheee#16 locates corresponding picture file json when searching for .MP4
refs [Wacheee#16] support MP4 with HEIC files too
refs Wacheee#16 locates corresponding picture file json when searching for .MP4
refs [[[Wacheee#15](Wacheee#15)] Fixed problem with files that only have the supplemental as .s.... by checking if the json format is already good and a corresponding file already exists Cached directory list on jsonForFile for speeding up process
Move live photos
…counter fix: add support for supplemental metadata json with counter
Author
Owner
|
Hey, I was on vacation, so I just saw this. I noticed you added commits unrelated to this functionality (e.g., you removed macos-13, which is needed to build executables for both CPU architectures on macOS). Could you open a PR with separate branches? That way it’ll be easier to debug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.