Open
Conversation
Philippe117
force-pushed
the
feature/allow_ssh
branch
from
f119cdc to
04b8b7d
Compare
duchainer
requested changes
May 27, 2020
Member
duchainer
left a comment
duchainer
left a comment
There was a problem hiding this comment.
Set $FORCE_SSH under https comments to false
Also make sure that the sed calls are valid git paths
script/install.sh
Outdated
|
|
||
| ###################################### | ||
| ## Set back to https if needed | ||
| if [[ $FORCE_SSH == "true" ]] |
Member
Author
There was a problem hiding this comment.
Si on a set à ssh, je remet à https pour éviter les conflits avec git
Member
Author
There was a problem hiding this comment.
comme ça, le .rosinstal utilise toujours https mais est changé au besoin. Un peut comme du JIT/JAT
script/scrape_config.sh
Outdated
|
|
||
| ###################################### | ||
| ## Set back to https if needed | ||
| if [[ $FORCE_SSH == "true" ]] |
Member
There was a problem hiding this comment.
Every https seems to have the wrong $FORCE_SSH value
Member
Author
There was a problem hiding this comment.
voir ma réponse au dessu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ajoute l'utilisation du ssh.
pour tester