Redesign settings page#42
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR redesigns the Settings page UI into two groups (schedule/timezone and language/display), switches system settings to autosave with a single global save indicator, and adds a standalone HTML prototype plus automated layout/content checks to guard the approved design.
Changes:
- Reworked
SettingsPage.sveltelayout into grouped rows, added global save status UI, and replaced the native time input with hour/minute/AM-PM selects + autosave. - Updated i18n strings and checks for the new grouped headings and time-field labels.
- Added an HTML prototype (
docs/prototypes/settings-v2.html) and a Node check script to validate key layout/content invariants.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/settings/system-settings.check.ts | Adds assertions to lock in the new SettingsPage structure and CSS snippets. |
| src/lib/settings/SettingsPage.svelte | Implements the new grouped layout, autosave queueing, time selects, new scale controls, and global save indicator. |
| src/lib/i18n/i18n.ts | Adds translation keys for new group headings and time select labels. |
| src/lib/i18n/i18n.check.ts | Adds checks for the new translated group headings. |
| scripts/settings-prototype.check.mjs | Adds validation checks for the standalone HTML prototype content/layout. |
| docs/superpowers/specs/2026-07-20-settings-html-prototype-design.md | Adds a spec document describing the prototype design and behavior. |
| docs/prototypes/settings-v2.html | Adds the standalone settings prototype with inline CSS/JS and localStorage persistence. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
npm testnpx svelte-check --tsconfig ./tsconfig.json