Skip to content

[chore] chore: remove planning files from git tracking #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wangmerlyn merged 1 commit into from
Mar 5, 2026
Merged

[chore] chore: remove planning files from git tracking #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,17 @@ venv.bak/

# mkdocs documentation
/site

# Planning files (created by planning-with-files skill)
/task_plan.md
/findings.md
/progress.md
task_plan.md
findings.md
progress.md
**/task_plan.md
**/findings.md
**/progress.md
Comment on lines 152 to +160
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There are multiple redundant patterns to ignore the planning files. The **/<filename> pattern is sufficient to ignore files with that name in any directory, making the other patterns for the same files unnecessary. This can be simplified for better clarity and maintainability.

**/task_plan.md
**/findings.md
**/progress.md

Comment on lines +158 to +160
Copy link
Contributor

@coderabbitai coderabbitai bot Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

# First, check the exact .gitignore content around lines 158-160
sed -n '150,165p' .gitignore

Repository: Wangmerlyn/KeepGPU

Length of output: 285

🏁 Script executed:

# Check if docs/plans directory exists and what files are in it
find docs/plans -type f -name "*.md" 2>/dev/null | head -20

Repository: Wangmerlyn/KeepGPU

Length of output: 44

🏁 Script executed:

# Run the verification script from the review comment
git check-ignore -v docs/plans/cli-service-dashboard/task_plan.md \
  docs/plans/cli-service-dashboard/findings.md \
  docs/plans/cli-service-dashboard/progress.md 2>&1 || echo "Files not ignored or directory/files do not exist"

Repository: Wangmerlyn/KeepGPU

Length of output: 288

These recursive ignore rules suppress required docs/plans/** planning files.

The patterns **/task_plan.md, **/findings.md, and **/progress.md (lines 158–160) actively suppress planning documentation under docs/plans/ that your workflow requires to be tracked. Scope these ignores to non-docs paths or add explicit negations.

Suggested patch 
 # Planning files (created by planning-with-files skill)
-/task_plan.md
-/findings.md
-/progress.md
-task_plan.md
-findings.md
-progress.md
-**/task_plan.md
-**/findings.md
-**/progress.md
+task_plan.md
+findings.md
+progress.md
+!docs/plans/**/task_plan.md
+!docs/plans/**/findings.md
+!docs/plans/**/progress.md
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.gitignore around lines 158 - 160, The three recursive ignore patterns
(**/task_plan.md, **/findings.md, **/progress.md) are too broad and are
unintentionally excluding required planning files under docs/plans; narrow their
scope or add explicit negations so docs/plans/** remains tracked. Update those
patterns by scoping them to the intended non-docs directories (e.g., limit to
specific folders where these files are generated) or add negation rules such as
excluding docs/plans/** (for example add !docs/plans/**/task_plan.md,
!docs/plans/**/findings.md, !docs/plans/**/progress.md) so files matching
task_plan.md, findings.md, and progress.md inside docs/plans are not ignored.

Comment on lines 152 to +160
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There are several redundant patterns here. To ignore these files in any directory, you only need to list their names. The patterns with a leading slash (/) and with a globstar (**/) are redundant. You can simplify this section to just the filenames.

task_plan.md
findings.md
progress.md


# mypy
.mypy_cache/
Expand Down
72 changes: 0 additions & 72 deletions docs/plans/cli-service-dashboard/findings.md
View file
Open in desktop

This file was deleted.

59 changes: 0 additions & 59 deletions docs/plans/cli-service-dashboard/progress.md
View file
Open in desktop

This file was deleted.

48 changes: 0 additions & 48 deletions docs/plans/cli-service-dashboard/task_plan.md
View file
Open in desktop

This file was deleted.