Skip to content

fix(i18n): complete safety-critical recovery copy in all 11 locales#172

Merged
Wangnov merged 3 commits into
mainfrom
codex/issue-166-i18n-safety-copy
Jul 11, 2026
Merged

fix(i18n): complete safety-critical recovery copy in all 11 locales#172
Wangnov merged 3 commits into
mainfrom
codex/issue-166-i18n-safety-copy

Conversation

@Wangnov

@Wangnov Wangnov commented Jul 10, 2026

Copy link
Copy Markdown
Owner

Summary

  • Complete native safety-critical copy for install.partial.*, settings.health.*, uninstall.status.*, and uninstall.partial.* across all 11 supported locales. Destructive and recovery actions now state their distinct consequences and interpolate the exact rendered action label.
  • Add release gates that preserve placeholder parity, reject copied English/Simplified-Chinese safety paragraphs unless an exact source-bound allowlist entry exists, and keep partial-uninstall recovery actions semantically distinct.
  • Exercise configuration recovery and partial-uninstall recovery in French, Arabic, Spanish, and Traditional Chinese, including RTL direction and localized confirmation/button order for Arabic.
  • Keep partial-install guidance truthful after renderer loss or an ambiguous Windows invoke result: retain bounded token-keyed completion evidence, re-probe disk/managed state, and suppress reinstall until the outcome is known.
  • Preserve all still-pending ancillary recovery actions when the user retries only one step, including deterministic provenance-missing branches on macOS and Windows; a successful retry can no longer erase a different unfinished cleanup action.
  • Treat a successful portable fresh-install rollback as a first-class terminal outcome: clear the transaction journal, emit structured rolled-back completion evidence, and release the renderer retry guard. Missing backups remain hard failures and an ambiguous MSIX result still takes precedence as outcome-unknown.

Validation

  • npm run check — pass
  • npm run lint — pass
  • npm test — pass (20 files / 143 tests)
  • npm run build — pass
  • cargo clippy --manifest-path src-tauri/Cargo.toml --workspace --all-targets -- -D warnings — pass
  • cargo test --manifest-path src-tauri/Cargo.toml --workspace — pass (97 tests)
  • cargo test --manifest-path crates/codex-win-engine/Cargo.toml --all-targets — pass (72 tests)
  • cargo test --manifest-path crates/codex-mac-engine/Cargo.toml --all-targets — pass (24 tests)
  • git diff --check origin/main...HEAD — pass
  • Exact codex review --base origin/mainpass: no P1/P2 and no findings (未发现明确且可操作的回归问题。)
  • GitHub PR checks — pass (6/6)

Deployment notes

None. No persisted-data migration is required; operation-completion evidence is bounded and process-local.

Closes #166

@Wangnov Wangnov marked this pull request as ready for review July 11, 2026 12:18
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@Wangnov Wangnov merged commit 8ec28a3 into main Jul 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(i18n): complete safety-critical recovery copy in all 11 locales

1 participant