fix(shell): enforce WebView trust boundaries and root crash recovery#173
Merged
Conversation
7 tasks
…ess-stop-recovery
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createRootfallback that cover providers,QuitConfirm, andShell; recovery surfaces log diagnostics, read backend operation snapshots, and keep quit decisions phase-aware.Validation
npm run check— passnpm run lint— passnpm test— pass (24 files / 166 tests)npm run build— pass, including renderer-entry isolation checkcargo clippy --manifest-path src-tauri/Cargo.toml --workspace --all-targets -- -D warnings— passcargo test --manifest-path src-tauri/Cargo.toml --workspace— pass (99 tests)cargo test --manifest-path crates/codex-mac-engine/Cargo.toml --all-targets— passcargo test --manifest-path crates/codex-win-engine/Cargo.toml --all-targets— passCmd+RandCmd+Premain blockedcodex review --base origin/main— pass: no P1/P2 and no findings (未发现会破坏现有功能或阻碍合并的缺陷。)git diff --check origin/main...HEAD— passDeployment notes
No migration is required. On Windows release builds, the main window intentionally remains hidden until the native WebView2 accelerator gate succeeds; an unsupported or failed gate shows a native startup error and exits instead of exposing an unsafe WebView. Development builds retain debugging behavior.
Closes #167