fix(windows): support constrained PowerShell sessions#179
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[pscustomobject]projections with plain hashtables so Authenticode, MSIX install/detection, health, removal, and capability reports remain serializable in PowerShell ConstrainedLanguageUnknownRoot cause
PowerShell ConstrainedLanguage rejects the
[pscustomobject]conversion used to build JSON reports. That caused the report command to exit before the manager could inspect the real Authenticode or installation result, which surfaced as a misleading signature-verification failure. This change keeps the existing fail-closed publisher/signature policy; it only makes report generation compatible with the restricted language mode.Validation
npm run checknpm run lintnpm test -- --run(118 passed)npm run buildcargo test --manifest-path crates/codex-win-engine/Cargo.toml --all-targets(70 passed)cargo check --manifest-path crates/codex-win-engine/Cargo.toml --target x86_64-pc-windows-msvc --all-targetscargo clippy --manifest-path src-tauri/Cargo.toml --workspace --all-targets -- -D warningscargo test --manifest-path src-tauri/Cargo.toml --workspace(92 passed)codex reviewon the uncommitted changes: no actionable findingsThe Windows CI leg will execute the new Windows-only PowerShell 5.1 ConstrainedLanguage tests.
Closes #178