Added background functionality#3
Open
MadalinaKhaji wants to merge 6 commits intoWappsto:masterfrom
Open
Conversation
mareklap
reviewed
Feb 12, 2020
| .find({ type: "Report" }) | ||
| .get("data"); | ||
|
|
||
| let CO2_value = sensors.find({ name: "CO2" }); |
Contributor
There was a problem hiding this comment.
either you use const or change it to a small letter
| panel.save( | ||
| { | ||
| data: | ||
| +Number(temp_data).toFixed(2) + |
Contributor
There was a problem hiding this comment.
In the end it will be converted to a string anyway since you're concatenating. You could maybe use ${...} (string interpolation).
| <head> | ||
| <meta charset="utf-8"> | ||
| <meta charset="utf-8" /> | ||
| <title></title> |
mareklap
reviewed
Feb 12, 2020
| @@ -0,0 +1,176 @@ | |||
| let Wappsto = require("wapp-api"); | |||
| @@ -0,0 +1,176 @@ | |||
| let Wappsto = require("wapp-api"); | |||
|
|
|||
| let wappsto = new Wappsto(); | |||
|
|
||
| let wappsto = new Wappsto(); | ||
|
|
||
| let wappstoConsole = require("wapp-api/console"); |
Contributor
There was a problem hiding this comment.
use const or require("wapp-api/console").start()
| subscribe: true | ||
| } | ||
| ) | ||
| .then(function(collection) { |
Contributor
There was a problem hiding this comment.
You could rewrite to the following form:
.then(collection) => {
...
}
|
|
||
| let device, sensors, led, data; | ||
|
|
||
| wappsto |
Contributor
There was a problem hiding this comment.
you could try to use async/await
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.