Reject extra keys schema validation#348
Closed
Scr4tch587 wants to merge 0 commit into
Closed
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Added an extra-key check to
validate()incore/runtime/validator.py. Before inserting builder output, thevalidator now raises
ValidationErrorif a row contains any key not declared in the dataset's schema.Added schema={"val": SchemaType.INT} to 4 worker unit tests whose mock output was silently passing the old
empty-schema check.
Why
Extra keys were silently dropped, which made schema drift hard to catch: builders could diverge from their
declared schema without any visible error.
Testing
test_validator.py: replaced the oldtest_extra_keys_allowed(which asserted the wrong behaviour) withtest_extra_keys_raises, confirming aValidationErroris raised with the expected message.test_schema_unexpected_keytotest_errors.py: builder returns a valid schema key plusan extra key, confirms the build returns 500 and no rows are inserted.