Skip to content

feat: add Store abstraction for build data access#352

Open
Scr4tch587 wants to merge 1 commit into
mainfrom
kai/dry-run-store
Open

feat: add Store abstraction for build data access#352
Scr4tch587 wants to merge 1 commit into
mainfrom
kai/dry-run-store

Conversation

@Scr4tch587

Copy link
Copy Markdown
Contributor

What

Put the build path's four data ops behind a Store ABC with two backends, and thread a store through the orchestrator and worker.

How

  • Store ABC over get_existing_timestamps, get_rows_range, get_rows_timestamps, insert_rows + build_lock
  • PostgresStore — thin shell forwarding to core.db.datasets
  • MemoryStore — in-process dict backend; json round-trip on insert mirrors Postgres Jsonb
  • store threaded run_build → execute_job → _fetch_dep_data
  • worker no longer calls core.db.datasets directly
  • store defaults to PostgresStore(), so existing callers are unchanged

Why

Lets the same build logic run against Postgres or an in-memory store, the groundwork for dry runs. No behavior change on its own.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant